Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachment): handle transient prefix #90

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

CoderPoet
Copy link
Member

What type of PR is this?

fix(attachment): When encoding and decoding attachments, handle transient prefixes correctly

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

Test Cases

1. dubbo-java-client -> kitex-go-server

image

2. kitex-go-client -> dubbo-java-server

image

3. kitex-go-client -> kitex-go-server

image

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoderPoet, DMwangnima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DMwangnima DMwangnima merged commit a4cf3c1 into kitex-contrib:main Apr 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants