Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zookeeper-registry): Support the options of WithoutKeepAlive for zookeeper(#86) #87

Closed
wants to merge 9 commits into from

Conversation

s5364733
Copy link

No description provided.

registries/zookeeper/registry/options.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/options.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/options.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/registry.go Outdated Show resolved Hide resolved
registries/zookeeper/resolver/options.go Outdated Show resolved Hide resolved
registries/zookeeper/resolver/options.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/registry.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/options.go Outdated Show resolved Hide resolved
registries/zookeeper/registry/options.go Outdated Show resolved Hide resolved
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DMwangnima, s5364733
To complete the pull request process, please assign yangruiemma after the PR has been reviewed.
You can assign the PR to them by writing /assign @yangruiemma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DMwangnima DMwangnima changed the title fix(resolve): Support the options of renewLease for zookeeper(#86) fix(zookeeper-registry): Support the options of WithoutKeepAlive for zookeeper(#86) Mar 27, 2024
@DMwangnima DMwangnima self-requested a review March 27, 2024 06:50
@felix021
Copy link
Contributor

This option may be dangerous: if it's set to false and accidentally deployed to online env, it may cause unexpected error.

This is not a good way to solve the original problem. A better approach would be to distinguish your local machine and testing/product env, and do not register into zk if it's not testing/product env.

@DMwangnima
Copy link
Collaborator

Development specification issues shouldn't be left to frameworks. I would close this PR and related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants