-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zookeeper-registry): Support the options of WithoutKeepAlive for zookeeper(#86) #87
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DMwangnima, s5364733 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This option may be dangerous: if it's set to false and accidentally deployed to online env, it may cause unexpected error. This is not a good way to solve the original problem. A better approach would be to distinguish your local machine and testing/product env, and do not register into zk if it's not testing/product env. |
Development specification issues shouldn't be left to frameworks. I would close this PR and related issue. |
No description provided.