-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add methods to bridge dubbo-hessian2 and kitex-hessian #33
Feature add methods to bridge dubbo-hessian2 and kitex-hessian #33
Conversation
49caaf3
to
6eefc96
Compare
type TestServiceEchoIntArgs struct { | ||
Req int32 `json:"req"` | ||
} | ||
func (p *EchoRequest) Encode(e codec.Encoder) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Encode
and Decode
functions are not used?
|
||
func init() { | ||
hessian.RegisterPOJO(&EchoRequest{}) | ||
hessian.RegisterPOJO(&EchoResponse{}) | ||
register(objects) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以直接调用 hessian2.Register,不用 register 函数了
} | ||
svcInfo := &kitex.ServiceInfo{ | ||
ServiceName: serviceName, | ||
HandlerType: handlerType, | ||
Methods: methods, | ||
KiteXGenVersion: "v0.6.1", | ||
PayloadCodec: kitex.Thrift, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Hessian2 here?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felix021, jasondeng1997, Lvnszn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
What type of PR is this?
add methods to bridge dubbo-hessian2 and kitex-hessian
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: