Add Cards #44
Open
Add Cards #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
navneetrai
commented
Oct 31, 2020
navneetrai
commented
- Added Charts as cards
dvanscott
requested changes
Jan 28, 2021
README.md
Outdated
Comment on lines
335
to
337
| ->chartModel(AppUser::class) | ||
| ->chartName('default') | ||
| ->width('1/2'), |
There was a problem hiding this comment.
Can we indent these lines for better readability?
README.md
Outdated
Comment on lines
339
to
341
| ->chartModel(AppUser::class) | ||
| ->chartName('earnings') | ||
| ->width('1/2'), |
There was a problem hiding this comment.
Can we indent these lines for better readability?
README.md
Outdated
Comment on lines
371
to
383
| ->chartModel(AppUser::class) | ||
| ->chartName('default') | ||
| ->settings([ | ||
| 'type' => 'bar', | ||
| 'titleProp' => 'name', | ||
| 'identProp' => 'id', | ||
| 'height' => 250, | ||
| 'indexColor' => '#999999', | ||
| 'color' => '#FF0000', | ||
| 'parameters' => ['January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December'], | ||
| 'options' => ['responsive' => true, 'maintainAspectRatio' => false], | ||
| ]) | ||
| ->width('1/2'), |
There was a problem hiding this comment.
Can we indent these lines for better readability?
Comment on lines
+4
to
+17
| <chartjs-bar-chart v-if="isType('bar')" | ||
| :dataset="comparisonDataset" | ||
| :additionalDatasets="card.additionalDatasets" | ||
| :settings="card.settings" | ||
| :height="card.settings.height" | ||
| :width="card.settings.width" | ||
| /> | ||
| <chartjs-line-chart v-else | ||
| :dataset="comparisonDataset" | ||
| :additionalDatasets="card.additionalDatasets" | ||
| :settings="card.settings" | ||
| :height="card.settings.height" | ||
| :width="card.settings.width" | ||
| /> |
There was a problem hiding this comment.
Are we able to use a dynamic component here since everything is the same except for the component itself? Maybe something along these lines:
<component :is="componentType" v-bind="options"></component>There was a problem hiding this comment.
@dvanscott This change is already a part of #41
Is it okay to handle it in that rebase?
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.