Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Going into settings resets the Date input field #29

Open
kiriDevs opened this issue Apr 6, 2022 · 3 comments
Open

Going into settings resets the Date input field #29

kiriDevs opened this issue Apr 6, 2022 · 3 comments
Labels
blocked This is waiting for something else bug Something isn't working

Comments

@kiriDevs
Copy link
Owner

kiriDevs commented Apr 6, 2022

Very minor, but kinda bugs me. Can probably be implemented with the same structure changes required for a better version of title:

Saving more than just the Substitutions in state - also save the date. That would allow the app to both replace the document.title with a string including the date and also to re-set the date input field to the date of the last request made. However, this would not help if no request was made before going into settings. That case needs further investigation.

@kiriDevs kiriDevs added bug Something isn't working help wanted Extra attention is needed labels Apr 6, 2022
@kiriDevs
Copy link
Owner Author

kiriDevs commented Apr 9, 2022

Also resets the already requested entries - it basically just wipes the HomeScreens state. Maybe investigate if there's a way to prevent that, otherwise just maintain that data somehow.

@kiriDevs
Copy link
Owner Author

This can be fixed using the <Offscreen /> component queued for release in React 18. Since this is not that urgent, I think we should just wait until that's done and then use it.

@kiriDevs kiriDevs added blocked This is waiting for something else and removed help wanted Extra attention is needed labels May 18, 2022
@kiriDevs
Copy link
Owner Author

Well, it isn't an input field anymore (dropdown) and the actual problem about this is that it re-fetches everything (after #69 is merged), but I'll keep this open for now since the point of the issue still applies.

@kiriDevs kiriDevs mentioned this issue Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This is waiting for something else bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant