Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script to calculate GPA for any semester or overall in college #64

Closed
wants to merge 1 commit into from

Conversation

gundeep77
Copy link

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

Please provide a brief summary here.

Screenshot

Attach any relevant screenshots or GIFs here.

Live Project Link

Include a link to the live project here.

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add input sanitization and more robust error handling
  • Implement unit tests to validate GPA calculations for different scenarios.
  • Create a requirements.txt and README.md for usability and setup.

@king04aman
Copy link
Owner

Hi @gundeep77 ,

I wanted to check in regarding the feedback provided in the last review. Do you have any updates on the changes? I’m looking forward to your progress!

@gundeep77
Copy link
Author

Hi @gundeep77 ,

I wanted to check in regarding the feedback provided in the last review. Do you have any updates on the changes? I’m looking forward to your progress!

Hey Aman,

I am really sorry man!
Got too busy with work. I wont be continuing this.
You can reject my PR

Sorry once again!

@king04aman
Copy link
Owner

It's okay @gundeep77 , thanks for the update.

@king04aman king04aman closed this Oct 22, 2024
Copy link
Contributor

👋 @king04aman 👋

Thanks for closing the pull request! Your contributions are valuable to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants