Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Client should not return null for 404 responses #135

Open
steven-barnes opened this issue Nov 15, 2024 · 1 comment
Open

Java Client should not return null for 404 responses #135

steven-barnes opened this issue Nov 15, 2024 · 1 comment

Comments

@steven-barnes
Copy link

For code like:

subscriptionApi.getSubscriptionByKey("xyzzy", requestOptions)

The client returns null on 404 errors. This is unexpected. The client should throw a KillBillClientException containing the response code.

@pierre
Copy link
Member

pierre commented Nov 16, 2024

Yes, we've talked about enhancing this in the past. This behaviour has been in place for 12+ years though, so it'd be a large breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants