Proxy Views: SCCharts-specific renderings #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddykasp
requested changes
Mar 3, 2023
...eler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/ControlflowRegionSynthesis.xtend
Outdated
Show resolved
Hide resolved
...eler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/ControlflowRegionSynthesis.xtend
Show resolved
Hide resolved
...eler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/ControlflowRegionSynthesis.xtend
Outdated
Show resolved
Hide resolved
...eler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/ControlflowRegionSynthesis.xtend
Outdated
Show resolved
Hide resolved
....kieler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/DataflowRegionSynthesis.xtend
Show resolved
Hide resolved
...arts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/filtering/SCChartsSemanticFilterTags.java
Show resolved
Hide resolved
....sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/styles/ControlflowRegionStyles.xtend
Show resolved
Hide resolved
...au.cs.kieler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/styles/StateStyles.xtend
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.scg.klighd/src/de/cau/cs/kieler/scg/klighd/SCGraphDiagramSynthesis.xtend
Outdated
Show resolved
Hide resolved
...ns/de.cau.cs.kieler.scg.klighd/src/de/cau/cs/kieler/scg/klighd/SCGraphDiagramSynthesis.xtend
Outdated
Show resolved
Hide resolved
NiklasRentzCAU
commented
Mar 3, 2023
...rts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/filtering/SCChartsSemanticFilterRules.java
Outdated
Show resolved
Hide resolved
NiklasRentzCAU
commented
Mar 3, 2023
....kieler.sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/DataflowRegionSynthesis.xtend
Outdated
Show resolved
Hide resolved
NiklasRentzCAU
commented
Mar 3, 2023
....sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/styles/ControlflowRegionStyles.xtend
Show resolved
Hide resolved
NiklasRentzCAU
commented
Mar 3, 2023
....sccharts.ui/src/de/cau/cs/kieler/sccharts/ui/synthesis/styles/ControlflowRegionStyles.xtend
Outdated
Show resolved
Hide resolved
Eddykasp
approved these changes
Mar 7, 2023
|
remove "filter" from filter names @Eddykasp |
This is now done by KLighD directly.
|
One thing that I noticed when looking at proxies in different contexts, was that it is sometimes hard to differentiate proxies from normal nodes. In some cases this makes them less helpful so it could be sensible to make proxy-specific rendering look slightly different than regular nodes, for example in colour. Something we should consider when developing proxies for other/new diagram types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #54
Dependency on kieler/KLighD#129