-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating maven projects in a subfolder #519
Comments
Curious how tinesoft does it |
@jbadeau I don't know about nx-spring-boot plugin and what i want to do is near what nx do with |
That will make the plugin hard to use and understand. For me we should use one maven for all projects. And we should have one root pom.xml (or inside mavenRootDirectory) so every pom.xml can inherent from it. |
another way to find mavenRootDirectory in my opinion is Edit: Nx show don't have tag option so this option not possible |
@jbadeau to make this feature simple I think about a fixed name for this subfolder. Let's say nx-maven. If a root pom.xml is present, we use empty string for mavenRootDirectoty. If not we generate everything in nx-maven subfolder For this, we just need to add a boolean to init generator |
It u have a prerelease I’ll be happy to try it |
@jbadeau I am working on implementing it |
Cool,
Much appreciated, just trying to avoid rework for you.
…On Tue, 17 Oct 2023 at 19:04, khalilou88 ***@***.***> wrote:
@jbadeau <https://github.com/jbadeau> I am working on implementing it
—
Reply to this email directly, view it on GitHub
<#519 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFJOYGNYILKNVPVOTVX23X723BZAVCNFSM6AAAAAA6AFVR52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWHAZDKOBWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Cool, just trying to avoid rework for you. |
looks like a standard way to add options to plugins |
@jbadeau seems what we are looking for (if I understand well) |
Ok, do u publish as prerelease or are u sure it’s fine?
…On Wed, 18 Oct 2023 at 14:47, khalilou88 ***@***.***> wrote:
@jbadeau <https://github.com/jbadeau> seems what we are looking for (if I
understand well)
But I am happy with the nx-maven as a subfolder. Finishing the tests and
will publish a new version
—
Reply to this email directly, view it on GitHub
<#519 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFJO5BXK4F6VZRSYKBILTX77FVPAVCNFSM6AAAAAA6AFVR52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGM3TSOJZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
prerelease don't work good for me, so i will publish a new version. |
I published version 0.12.0 with this feature. Please use |
works! :) Any change we can customize the subfolder name? I could make a pr. |
For now it's not possible, but if you can find the rootproject based on a tag or variable, we can update this function:
EDIT: MavenRootDirectory will be a variable inside nx.json |
closing this issue. next changes will be here #535 |
This option is changed in version 0.13.0 to be mavenRootDirectory |
To isolate maven root project from nx root project and have better affected experience we are planning to generate all maven project in a sub folder.
For that we will use a
mavenRootDirectory
variable.during init we need to to choose this variable
we will try to put it inside nx.json as a first option, or inside a
.env file
(in root folder)EDIT:
https://nx.dev/recipes/tips-n-tricks/define-environment-variables
NX_maven_Root_Directory inside
.env
fileEDIT: final solution use nx-maven subefloder without use of a en var
The text was updated successfully, but these errors were encountered: