Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues 10, 20, 25, 26 #33

Merged
merged 10 commits into from
Jul 18, 2024
Merged

issues 10, 20, 25, 26 #33

merged 10 commits into from
Jul 18, 2024

Conversation

elsdvlee
Copy link
Collaborator

@elsdvlee elsdvlee commented Jul 15, 2024

What's changed

Added mixed content specification.
Adapted field specification.
Adapted example 9.

Change checklist

  • updated ontology, where necessary
  • updated shapes, where necessary
  • added or updated test cases, where necessary
  • any TODOs have been turned into trackable issues and referenced where necessary

Issue reference

Fixes #10.
Fixes #20.
Fixes #25.
Fixes #26.

@elsdvlee elsdvlee marked this pull request as draft July 15, 2024 10:05
@elsdvlee elsdvlee requested a review from pmaria July 15, 2024 10:05
@elsdvlee elsdvlee changed the title fixes issue 25, draft solution issues 9, 10 and 26 fixes issues 9, 10, 25, 26 Jul 15, 2024
@elsdvlee elsdvlee changed the title fixes issues 9, 10, 25, 26 issues 9, 10, 25, 26 Jul 15, 2024
@elsdvlee elsdvlee marked this pull request as ready for review July 15, 2024 14:33
@elsdvlee elsdvlee changed the title issues 9, 10, 25, 26 issues 10, 20, 25, 26 Jul 16, 2024
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor points in comments.

As discussed I have some other concerns regarding aspects that are currently described as part of an rml:Source like rml:null or CSVW descriptions which we cannot reuse in fields in the current state of rml-lv vs rml-io. But we can raise a different issue for this.

spec/section/fields.md Outdated Show resolved Hide resolved
spec/section/fields.md Outdated Show resolved Hide resolved
spec/section/fields.md Show resolved Hide resolved
spec/section/fields.md Outdated Show resolved Hide resolved
spec/section/fields.md Outdated Show resolved Hide resolved
spec/section/views.md Outdated Show resolved Hide resolved
spec/section/fields.md Outdated Show resolved Hide resolved
@elsdvlee
Copy link
Collaborator Author

elsdvlee commented Jul 18, 2024

Made issue 34 for the unresolved point.

@elsdvlee elsdvlee merged commit 99e4a22 into main Jul 18, 2024
1 check failed
@elsdvlee elsdvlee deleted the issue_10 branch July 18, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants