Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Key Mapper only executes the oldest shortcut that it knows about from the app "HTTP Request Shortcuts" #1222

Open
4 tasks
sudomain opened this issue Jun 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sudomain
Copy link

sudomain commented Jun 5, 2024

Developer TODO (don't remove)

  • create new branch. put issue number at start of name if not a very quick fix.
  • write tests. put issue number in comment
  • update documentation
  • merge and delete branch (don't squash because want commit history to see why I made changes)

Discord message link/email recipient

Describe the bug
I was hoping to use the shortcuts from app HTTP Requests Shortcuts in order to send HTTP requests for certain keys. There is a bug where if two or more of the shortcuts from this app are used as Key Mapper actions, only the older one will get executed. In the following example, the "Button_L1" shortcut will get executed for both mappings:
Screenshot_20240605-185919

When selecting a shortcut, the HTTP requests app allows selecting "Default" or "Legacy" placement method:
Screenshot_20240605-183513
If "Default" is used, then the keymapper action will give a toast with a message of Error opening this app shortcut. However, if Legacy is used, we encounter the overwriting bug I described above.

To Reproduce

  1. Install HTTP requests shortcuts app
  2. Create 2 or more shortcuts in that app. It doesn't matter if the request itself is valid because the wrong shortcut is opened and it shows the wrong shortcut name (Button_L1 in my example)
  3. Try to run the Button_R2 shortcut/action, either using the trigger or tapping on the action

Upload a backup of your keymaps. Follow the guide here
button_l1_r1_http_shortcuts_bug.zip

Expected behavior
The correct shortcut to get run, instead of the oldest one key mapper knows about from the app. Maybe the "Default" shortcut type can be supported? I think these are called "widgets" and can be renamed?

Screenshots
See above

Smartphone (please complete the following information):

  • Device: Pixel 2
  • Android version: Android 11

Additional context
Add any other context about the problem here.

@sudomain sudomain added the bug Something isn't working label Jun 5, 2024
@sudomain sudomain changed the title Bug: "Legacy" shortcuts from the app "HTTP Request Shortcuts" get overwritten when a new one is added Bug: Key Mapper only executes the oldest shortcut that it knows about from the app "HTTP Request Shortcuts" Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants