Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to run cargo-audit security audit #647

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ansasaki
Copy link
Contributor

@ansasaki ansasaki commented Sep 6, 2023

Move the cargo-audit run from the static analysis job to a dedicated workflow using the github action instead of running the tool manually.

This improves the visibility of detected issues as the github action can use the checks interface and also create issues automatically.

The workflow runs cargo audit on pushes to master branch, when tags are created, or when a PR modifies dependencies (Cargo.toml or Cargo.lock)

Move the cargo-audit run from the static analysis job to a dedicated
workflow using the github action instead of running the tool manually.

This improves the visibility of detected issues as the github action can
use the checks interface and also create issues automatically.

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #647 (61fe148) into master (d27b209) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 59.46% <ø> (-0.01%) ⬇️
upstream-unit-tests 59.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't see the workflow run on this PR, but I suppose that is because Cargo.toml nor Cargo.lock is untouched.

@ansasaki ansasaki merged commit 73ea560 into keylime:master Sep 7, 2023
12 checks passed
@ansasaki ansasaki deleted the add_cargo_audit branch September 7, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants