Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if EK cert from NV Index is an valid certificate #787

Open
THS-on opened this issue May 7, 2024 · 2 comments
Open

Check if EK cert from NV Index is an valid certificate #787

THS-on opened this issue May 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@THS-on
Copy link
Member

THS-on commented May 7, 2024

We have seen some TPMs where the EK certificate for RSA2048 are padded with ones up to the length of 1600 bytes.

This causes the agent to fail to register, as we don't expect that large certificates and the full NVR is also not a valid certificate.
To work around this, one option is to parse the data to check the actual length of the DER data structure.

@ansasaki ansasaki added the bug Something isn't working label May 8, 2024
@THS-on
Copy link
Member Author

THS-on commented Sep 19, 2024

@ansasaki should we just implement the check by parsing the DER structure? I have that code mostly ready anyway for that

@ansasaki
Copy link
Contributor

@ansasaki should we just implement the check by parsing the DER structure? I have that code mostly ready anyway for that

Yes, I think that could be sufficient to avoid this issue

@THS-on THS-on self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants