Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish agent on crates.io #473

Open
THS-on opened this issue Nov 3, 2022 · 6 comments
Open

Publish agent on crates.io #473

THS-on opened this issue Nov 3, 2022 · 6 comments

Comments

@THS-on
Copy link
Member

THS-on commented Nov 3, 2022

I looked into packaging the rust agent for Debian and it makes it a lot easier if the agent is published on crates.io.

@lkatalin @ansasaki @ueno does anyone of you have the permission to create an account and publish to it?

@ansasaki
Copy link
Contributor

ansasaki commented Nov 3, 2022

@THS-on I can check what is needed

@ueno
Copy link
Contributor

ueno commented Nov 3, 2022

Just a reminder: that would require renaming of the source package in Fedora (currently it is keylime-agent-rust, then it will need to be rust-keylime) and we might have to go through the review process again.

@aplanas
Copy link
Contributor

aplanas commented Nov 4, 2022

in openSUSE[1] the package is also named "rust-keylime", but the container image was also renamed to "keylime-agent"

[1] https://build.opensuse.org/package/view_file/openSUSE:Factory/rust-keylime/rust-keylime.spec?expand=1
[2] https://build.opensuse.org/package/view_file/openSUSE:Factory/rust-keylime-image/Dockerfile?expand=1

@ueno
Copy link
Contributor

ueno commented Dec 5, 2022

IMO, publishing the crate with the current state seems like more trouble than it's worth: nobody other than downstream packaging would use it through the tooling around crates.io. I would suggest first refactoring the crate into a reusable library crate and the application crates; that way, it would make more sense to have it on crates.io (e.g., allowing alternative agent implementation), while it would give us an opportunity to polish the library interface. I've created #481 as an initial attempt.

@toabctl
Copy link

toabctl commented May 12, 2023

@ueno given that #481 got merged, do you plan to publish on crates.io ?

@ueno
Copy link
Contributor

ueno commented May 14, 2023

@toabctl Thank you for the reminder. I haven't had time to work on that lately, but apparently the plan was to polish the library crate (keylime) by porting reusable functions from the application crates (keylime_agent and keylime_ima_emulator), before publishing those on crates.io (so we can maintain semver easily). Currently, only a few facilities have been ported and the suggested strategy was to port from low-level to high-level (keylime/meetings#58 (comment)).

That said, I wouldn't block on that, if there is any important use-case of published crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants