Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO CI: Updating the CI system to install and run minikube #42

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

galmasi
Copy link

@galmasi galmasi commented Dec 4, 2023

Just a small step in the direction of fully integrated test the attestation operator.

Signed-off-by: George Almasi <[email protected]>
@galmasi
Copy link
Author

galmasi commented Dec 11, 2023

I have removed the "do not merge" label. However, the GH action will not run correctly on PRs from forked repositories until after this current PR is merged. Please merge this, and I will open another PR right away just to test whether we can get a pass from GHA this time.

For those interested in the minutiae -- the difference is between marking an action "pull_request" vs "pull_request_target"; for the former, the commit triggering the workflow is the last commit on the branch that is subject of the pull request; for the latter, the branch triggering the workflow is the base branch from which the workflow is derived. The latter is marginally safer, and therefore GH allows the secrets associated with the repo owner organization onto it.

@maugustosilva maugustosilva merged commit e99b07c into keylime:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants