Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions not correctly linking issues and not auto-close bugs #513

Open
mposolda opened this issue Nov 21, 2023 · 2 comments
Open

GH actions not correctly linking issues and not auto-close bugs #513

mposolda opened this issue Nov 21, 2023 · 2 comments
Labels
Milestone

Comments

@mposolda
Copy link
Contributor

mposolda commented Nov 21, 2023

Describe the bug

  • When I send PR with commit stating closes #12345, it should be automatically linked to the quickstart issue #12345. Currently it is not.

  • When I merge PR linked with the issue #12345, it should automatically close that issue.

  • Will be nice to update PR template, so people are always sending PR against main branch. Not against latest branch.

Version

22.0.5

Expected behavior

See the description

Actual behavior

  • When I send PR for the issue, it can be nice if it is auto-linked to the target PR

  • Linked issue is not auto-closed when PR is merged

  • People are often sending PR against latest branches. PR template should be improved to adding some instructions mentioning that people should send PR against main, not against latest branch.

How to Reproduce?

No response

Anything else?

No response

@mposolda
Copy link
Contributor Author

Adding to 24 for now, but we can consider postponing if we have other priorities...

@hmlnarik
Copy link
Contributor

The first two items - automatic PR linking to issue, and closing that issue - is caused by GH policy since the described behaviour only works for PRs that target default repository branch which is latest, but most PRs are for main:

Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues. If you want to link a pull request to an issue using a keyword, the PR must be on the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants