Importing CLD models from FCCDetectors, new CLD Model with overlaps fixed #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
commented
Jul 7, 2023
andresailer
commented
Jul 7, 2023
Zehvogel
reviewed
Jul 7, 2023
Zehvogel
suggested changes
Jul 7, 2023
FCCee/CLD/compact/CLD_o2_v05/BeamInstrumentation_o3_v02_fitShield.xml
Outdated
Show resolved
Hide resolved
Zehvogel
reviewed
Jul 10, 2023
Zehvogel
reviewed
Jul 12, 2023
| <constant name="DetID_LumiCalCooling" value=" 17"/> | ||
| <constant name="DetID_LumiCalNoseShield" value=" 22"/> | ||
|
|
||
| <constant name="DetID_HOMAbsorber" value=" 19"/> |
There was a problem hiding this comment.
Do we still need an ID for the HOMAbsorber if we no longer have a HOMAbsorber?
andresailer
commented
Jul 12, 2023
andresailer
commented
Jul 13, 2023
armin-ilg
reviewed
Jul 14, 2023
armin-ilg
reviewed
Jul 14, 2023
|
Hi @andresailer I also agree with @armin-ilg that the central chamber should be described as 3 layers, but if it is technically challenging I think also the mixed material could work. I am also working on the CAD model import for the beam pipe, I will try to make a PR this week, so that we have also the copper cooling sections and a more realistic profile for the conical/trapezoidal section (which now is circular, but in reality should be elliptical). |
The vertex and beampipe radii are larger than they should be for an option 2 model
…umical and beampipe design with parafin cooling
The geant version in LCG_103 prints some verbose warnings about the fourth TA Shield, this seems to be spurious and due to a faulty check of rmin vs rmax? This only happens when the detector is drawn. Overlap check is clean
Fix overlap of modules going outside the envelope by reducing the inner clearance to 149 mrad half opening angle
The number of modules around phi has to be the same for all radii, use the correct module to cover the complete phi angle
…ing to too large radius
Zehvogel
approved these changes
Aug 23, 2023
andresailer
added a commit
to andresailer/lcgeo
that referenced
this pull request
Sep 22, 2023
andresailer
added a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
FCCee_o2_v03: Copy of FCCDetectors FCC_o2_v03, and renaming of XML files to make diff with existing models easier, this model is obsolete
FCCee_o2_v04: Copy of FCCDetectors FCC_o2_v04, and renaming of XML files to make diff easier
CLD_o2_v05: New implementation of the CLD detector with small beampipe design according to latest standard design; modified vertex detector to fit into the beampipe constraints (reduced length of all barrel layers, based on FCCee_o2_v02 from k4Geo); fixed overlaps in Inner and Outer Tracker
ENDRELEASENOTES
Todo: