Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing also with nightlies #319

Closed
BrieucF opened this issue Feb 14, 2024 · 11 comments
Closed

Tests failing also with nightlies #319

BrieucF opened this issue Feb 14, 2024 · 11 comments

Comments

@BrieucF
Copy link
Contributor

BrieucF commented Feb 14, 2024

The tests are now failing with the nightlies: https://github.com/key4hep/k4geo/actions/runs/7901882590/job/21566280656?pr=318#step:8:352 . It seems to be linked to the surface plugin. And indeed it looks like tests for detector not using surfaces are passing:

2024-02-14T13:44:11.2288800Z 
2024-02-14T13:44:11.2288985Z       Start 15: t_test_ALLEGRO_o1_v02
2024-02-14T13:46:38.8529780Z 15/19 Test #15: t_test_ALLEGRO_o1_v02 ............   Passed  153.07 sec
2024-02-14T13:46:38.8533506Z       Start 16: t_test_ARC_o1_v01_run
2024-02-14T13:47:19.9920566Z 16/19 Test #16: t_test_ARC_o1_v01_run ............   Passed   41.13 sec
2024-02-14T13:47:19.9922024Z       Start 17: t_test_ARC_o1_v01_overlap
2024-02-14T13:50:23.6337826Z 17/19 Test #17: t_test_ARC_o1_v01_overlap ........   Passed  183.64 sec
2024-02-14T13:50:23.6342638Z       Start 18: t_SensThickness_Clic_o2_v4
2024-02-14T13:50:25.6833410Z 18/19 Test #18: t_SensThickness_Clic_o2_v4 .......   Passed    2.05 sec
2024-02-14T13:50:25.6835990Z       Start 19: t_SensThickness_CLIC_o3_v15
2024-02-14T13:50:54.7714564Z 19/19 Test #19: t_SensThickness_CLIC_o3_v15 ......   Passed   29.07 sec
2024-02-14T13:50:54.7738815Z 
2024-02-14T13:50:54.7739458Z 26% tests passed, 14 tests failed out of 19
2024-02-14T13:50:54.7740043Z 
2024-02-14T13:50:54.7806437Z Errors while running CTest
2024-02-14T13:50:54.7809216Z Total Test time (real) = 1466.54 sec
2024-02-14T13:50:54.7809668Z 
2024-02-14T13:50:54.7809864Z The following tests FAILED:
2024-02-14T13:50:54.7810859Z 	  1 - t_test_ILD_l5_v02 (Failed)
2024-02-14T13:50:54.7811642Z 	  2 - t_test_ILD_s5_v02 (Failed)
2024-02-14T13:50:54.7815772Z 	  3 - t_test_ILD_l5_v09 (Failed)
2024-02-14T13:50:54.7816412Z 	  4 - t_test_ILD_l5_v10 (Failed)
2024-02-14T13:50:54.7817321Z 	  5 - t_test_ILD_l5_v11 (Failed)
2024-02-14T13:50:54.7817902Z 	  6 - t_test_SiD_o2_v03 (Failed)
2024-02-14T13:50:54.7818454Z 	  7 - t_test_SiD_o2_v04 (Failed)
2024-02-14T13:50:54.7819015Z 	  8 - t_test_CLIC_o1_v01 (Failed)
2024-02-14T13:50:54.7819575Z 	  9 - t_test_CLIC_o2_v04 (Failed)
2024-02-14T13:50:54.7820177Z 	 10 - t_test_CLIC_o3_v15 (Failed)
2024-02-14T13:50:54.7820747Z 	 11 - t_test_FCCee_o1_v05 (Failed)
2024-02-14T13:50:54.7821775Z 	 12 - t_test_CLD_o2_v05 (Failed)
2024-02-14T13:50:54.7822391Z 	 13 - t_test_steeringFile (Failed)
2024-02-14T13:50:54.7823009Z 	 14 - t_test_IDEA_o1_v02 (Failed)
2024-02-14T13:50:54.7853798Z ##[error]Process completed with exit code 8.
2024-02-14T13:50:54.8169525Z Post job cleanup.
@BrieucF BrieucF changed the title ILD test failing Tests failing also with nightlies Feb 14, 2024
@tmadlener
Copy link
Contributor

The problem seems to be that some extension is missing or has gone missing (from the failing logs):

2024-02-14T14:41:48.5236146Z ObjectExtensions::extension ERROR The object has no extension of type 9B1482D0F2AFA965.

@tmadlener
Copy link
Contributor

It's this PR that broke things, I think: AIDASoft/DD4hep#1226

@andresailer given the size of that I have no idea what exactly broke things.

@tmadlener
Copy link
Contributor

It also looks like things are running in principle (or at least not crashing). For k4geo it looks like the regex in the CMake config is the thing that makes the test fail.

@andresailer
Copy link
Contributor

We don't need the surfaces in the simulation (if that is what is missing), but we do need them for the reconstruction.

@MarkusFrankATcernch
Copy link
Contributor

The surface change cannot be the reason. This is only additional code.
It can only be that the typeid-name somehow changed due to the explicit namespace requirement.

Can one somehow reproduce it? In principle it is enough to beak when this is printed and
check the typeid of the requested object. Then I could create a test doing the same.....

@andresailer
Copy link
Contributor

Should be fixed with the nightlies for tomorrow.

@andresailer
Copy link
Contributor

Now the tests are failing because the key4hep action doesn't do install before running ctest
Pinging @jmcarcell

@jmcarcell
Copy link
Contributor

I added that back, forgot we don't have that working here. Anyway I ran it this morning and there are still some tests failing

@andresailer
Copy link
Contributor

I added that [what? where?] back, forgot we don't have that working here. Anyway I ran it [what?] this morning and there are still some tests failing [where?].

@jmcarcell
Copy link
Contributor

I wanted to mean that the CI installs now and tests are failing: https://github.com/key4hep/k4FWCore/actions/runs/7928420929/job/21646633246?pr=173

@andresailer
Copy link
Contributor

All tests in k4geo are now OK, except the occasional timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants