-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing also with nightlies #319
Comments
The problem seems to be that some extension is missing or has gone missing (from the failing logs):
|
It's this PR that broke things, I think: AIDASoft/DD4hep#1226 @andresailer given the size of that I have no idea what exactly broke things. |
It also looks like things are running in principle (or at least not crashing). For k4geo it looks like the regex in the CMake config is the thing that makes the test fail. |
We don't need the surfaces in the simulation (if that is what is missing), but we do need them for the reconstruction. |
The surface change cannot be the reason. This is only additional code. Can one somehow reproduce it? In principle it is enough to beak when this is printed and |
Should be fixed with the nightlies for tomorrow. |
Now the tests are failing because the key4hep action doesn't do install before running ctest |
I added that back, forgot we don't have that working here. Anyway I ran it this morning and there are still some tests failing |
|
I wanted to mean that the CI installs now and tests are failing: https://github.com/key4hep/k4FWCore/actions/runs/7928420929/job/21646633246?pr=173 |
All tests in k4geo are now OK, except the occasional timeout. |
The tests are now failing with the nightlies: https://github.com/key4hep/k4geo/actions/runs/7901882590/job/21566280656?pr=318#step:8:352 . It seems to be linked to the surface plugin. And indeed it looks like tests for detector not using surfaces are passing:
The text was updated successfully, but these errors were encountered: