diff --git a/k4MarlinWrapper/scripts/convertMarlinSteeringToGaudi.py b/k4MarlinWrapper/scripts/convertMarlinSteeringToGaudi.py index 5413bce4..d0bfcf8c 100755 --- a/k4MarlinWrapper/scripts/convertMarlinSteeringToGaudi.py +++ b/k4MarlinWrapper/scripts/convertMarlinSteeringToGaudi.py @@ -86,10 +86,6 @@ def convertConstants(lines, tree): """ Find constant tags, write them to python and replace constants within themselves """ constants = dict() - constElements = tree.findall('constants/include') - if constElements: - print('WARNING: include statements found inside constants tag') - constElements = tree.findall('constants/constant') for const in constElements: constants[const.attrib.get('name')] = getValue(const) @@ -249,7 +245,16 @@ def convertProcessors(lines, tree, globParams, constants): return lines +def findWarnIncludes(tree): + """Check the parsed XML structure for include statments and issue a warning""" + if any(True for _ in tree.iter("include")): + print("WARNING: Found at least one statement in the Marlin steering file") + print(" These cannot be handled by the conversion script.") + print(" Use Marlin -n to resolve these includes and convert the output of that") + + def generateGaudiSteering(tree): + findWarnIncludes(tree) globParams = getGlobalParameters(tree) lines = [] createHeader(lines)