Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting RPATH #99

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Setting RPATH #99

merged 2 commits into from
Aug 2, 2023

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Feb 28, 2023

BEGINRELEASENOTES

  • Sets RPATH, so installed libs are not stripped
    ENDRELEASENOTES

@andresailer
Copy link
Contributor

Please use the whole RPATH things as linked to from key4hep/k4-project-template#12

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Feb 28, 2023

Would K4FWCORE_SET_RPATH option be useful?

@andresailer
Copy link
Contributor

Thanks. Probably the option will be useful?

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Feb 28, 2023

I mean, whether there is a need to not set RPATH for the installed executables/libs.

@andresailer
Copy link
Contributor

If you put everything in a "view" structure in the end, you don't want RPATH, so it could be useful.

@jmcarcell
Copy link
Contributor

Let's merge this which would fix one issue. We should also have this in k4-project-template.

@jmcarcell jmcarcell merged commit 338f4ec into key4hep:main Aug 2, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjvbrt @andresailer @jmcarcell