Fix accessing metadata with MetaDataHandle
when MetadataSvc
is present
#231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
MetaDataHandle
when used withIOSvc
ENDRELEASENOTES
Fixes for
MetaDataHandle
interoperability withPodioDataSvc
and newMetadataSvc
/IOSvc
introduced in #215:MetaDataHandle::get_optional
wasn't checking whetherPodioDataSvc
orIOSvc
is usedMetaDataHandle::get
didn't check validity of optional when used withIOSvc
And some additional cleanup:
service
by default initializes a service if it's missing, hence the check was always trueThis is PR is orthogonal and doesn't depend on #223