Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing metadata with MetaDataHandle when MetadataSvc is present #231

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Sep 3, 2024

BEGINRELEASENOTES

  • Fixed missing checks for accessing metadata with MetaDataHandle when used with IOSvc

ENDRELEASENOTES

Fixes for MetaDataHandle interoperability with PodioDataSvc and new MetadataSvc/IOSvc introduced in #215:

  • MetaDataHandle::get_optional wasn't checking whether PodioDataSvc or IOSvc is used
  • MetaDataHandle::get didn't check validity of optional when used with IOSvc

And some additional cleanup:

  • removed constructor with missing definition (unused otherwise that would be an error)
  • removed workaround for checking service existence. Gaudi's service by default initializes a service if it's missing, hence the check was always true

This is PR is orthogonal and doesn't depend on #223

@jmcarcell jmcarcell enabled auto-merge (squash) September 4, 2024 14:52
@jmcarcell jmcarcell merged commit 94dd0d0 into key4hep:main Sep 4, 2024
3 of 7 checks passed
@m-fila m-fila deleted the metadatahandle branch September 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants