Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k4run: add missing import for VERBOSE #137

Merged
merged 2 commits into from
Aug 14, 2023
Merged

k4run: add missing import for VERBOSE #137

merged 2 commits into from
Aug 14, 2023

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Aug 11, 2023 •
edited by vvolkl
Loading

BEGINRELEASENOTES

  • k4run: fix missing import for VERBOSE

ENDRELEASENOTES

@Zehvogel
Copy link
Contributor

Another thing I forgot.. :D thx! Might feel like a bit overkill to also have a test for this but I think it won't hurt.

@kjvbrt
Copy link
Contributor Author

kjvbrt commented Aug 11, 2023

This one is quite old.

Zehvogel
Zehvogel approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@Zehvogel Zehvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Zehvogel
Copy link
Contributor

pinging @hegner as everyone else is on vacation afaik

@vvolkl vvolkl changed the title Import VERBOSE k4run: add missing import VERBOSE Aug 14, 2023
@vvolkl vvolkl changed the title k4run: add missing import VERBOSE k4run: add missing import for VERBOSE Aug 14, 2023
@vvolkl vvolkl merged commit 97ead95 into key4hep:main Aug 14, 2023
2 of 5 checks passed
@kjvbrt kjvbrt deleted the verbose branch August 14, 2023 09:20
@jmcarcell jmcarcell mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zehvogel Zehvogel Zehvogel approved these changes

@vvolkl vvolkl vvolkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjvbrt @Zehvogel @vvolkl