-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add automatic Frame legacy read #103
Conversation
@andresailer - after the discussion yesterday. There is a bug to likely fix externally first, but this should be the code needed on FWK side. We can wait for this or merge #100 independently. |
@tmadlener - working on this showed an interesting incident, why moving to frames was the right thing. We have https://github.com/key4hep/k4FWCore/blob/master/k4FWCore/components/PodioOutput.cpp#L108 that uses the old schema for the collection info. Even though the PODIO used does the newer schema. Thus legacy files written with PodioOutput are not compatible with plain PODIO. Unfortunately we may need to put the error handling into PODIO itself into the ROOTLegacyReader. |
Could the old schema version for collection info be the root cause for #95? Putting the handling of that into the ROOTLegacyReader sounds fine to me. |
Yes, that could be an explanation for #95. |
This needs a rebase and conflict resolution if still valid? |
091f91d
to
c35bd36
Compare
Rebased onto the latest master and things should be compiling again. As discussed during the last key4hep meeting, this should be able to read legacy files as written by the |
c35bd36
to
fc99692
Compare
Can we close this? We are already going to have files pre EDM4hep 1.0 (these will be the "legacy" ones) and after EDM4hep 1.0 |
I think we can close this for now and come back if we actually need this functionality in the future. |
BEGINRELEASENOTES
ENDRELEASENOTES
This PR is WIP. It seems to suffer from a bug in underlying libs which need to be addressed first.