Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add automatic Frame legacy read #103

Closed
wants to merge 4 commits into from

Conversation

hegner
Copy link
Contributor

@hegner hegner commented May 17, 2023

BEGINRELEASENOTES

  • Transparent handling when reading legacy PODIO files

ENDRELEASENOTES

This PR is WIP. It seems to suffer from a bug in underlying libs which need to be addressed first.

@hegner hegner requested a review from tmadlener May 17, 2023 12:42
@hegner
Copy link
Contributor Author

hegner commented May 17, 2023

@andresailer - after the discussion yesterday. There is a bug to likely fix externally first, but this should be the code needed on FWK side. We can wait for this or merge #100 independently.

@hegner
Copy link
Contributor Author

hegner commented May 17, 2023

@tmadlener - working on this showed an interesting incident, why moving to frames was the right thing. We have https://github.com/key4hep/k4FWCore/blob/master/k4FWCore/components/PodioOutput.cpp#L108 that uses the old schema for the collection info. Even though the PODIO used does the newer schema. Thus legacy files written with PodioOutput are not compatible with plain PODIO. Unfortunately we may need to put the error handling into PODIO itself into the ROOTLegacyReader.

@tmadlener
Copy link
Contributor

Could the old schema version for collection info be the root cause for #95?

Putting the handling of that into the ROOTLegacyReader sounds fine to me.

@hegner
Copy link
Contributor Author

hegner commented May 19, 2023

Yes, that could be an explanation for #95.

@andresailer
Copy link
Contributor

This needs a rebase and conflict resolution if still valid?

@tmadlener
Copy link
Contributor

Rebased onto the latest master and things should be compiling again. As discussed during the last key4hep meeting, this should be able to read legacy files as written by the podio::ROOTWriter, but will most likely fail to read legacy files produced by k4FWCore. In order to make that work it is still necessary to repackage the current (k4FWCore) legacy input system to produce Frame(Data).

@jmcarcell
Copy link
Contributor

Can we close this? We are already going to have files pre EDM4hep 1.0 (these will be the "legacy" ones) and after EDM4hep 1.0

@tmadlener
Copy link
Contributor

I think we can close this for now and come back if we actually need this functionality in the future.

@jmcarcell jmcarcell closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants