From 9b1aa1578a9c7f7d46d09020efa7d74c38307c2a Mon Sep 17 00:00:00 2001 From: jmcarcell Date: Fri, 1 Sep 2023 12:59:56 +0200 Subject: [PATCH] Fix clang warnings by adding final --- k4FWCore/include/k4FWCore/PodioDataSvc.h | 12 ++++++------ k4FWCore/include/k4FWCore/PodioLegacyDataSvc.h | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/k4FWCore/include/k4FWCore/PodioDataSvc.h b/k4FWCore/include/k4FWCore/PodioDataSvc.h index cc1faf4f..42d9a06e 100644 --- a/k4FWCore/include/k4FWCore/PodioDataSvc.h +++ b/k4FWCore/include/k4FWCore/PodioDataSvc.h @@ -45,12 +45,12 @@ class PodioDataSvc : public DataSvc { public: typedef std::vector> CollRegistry; - virtual StatusCode initialize(); - virtual StatusCode reinitialize(); - virtual StatusCode finalize(); - virtual StatusCode clearStore(); - virtual StatusCode i_setRoot(std::string root_path, IOpaqueAddress* pRootAddr); - virtual StatusCode i_setRoot(std::string root_path, DataObject* pRootObj); + StatusCode initialize() final; + StatusCode reinitialize() final; + StatusCode finalize() final; + StatusCode clearStore() final; + StatusCode i_setRoot(std::string root_path, IOpaqueAddress* pRootAddr) final; + StatusCode i_setRoot(std::string root_path, DataObject* pRootObj) final; /// Standard Constructor PodioDataSvc(const std::string& name, ISvcLocator* svc); diff --git a/k4FWCore/include/k4FWCore/PodioLegacyDataSvc.h b/k4FWCore/include/k4FWCore/PodioLegacyDataSvc.h index fe4052d7..e37295e7 100644 --- a/k4FWCore/include/k4FWCore/PodioLegacyDataSvc.h +++ b/k4FWCore/include/k4FWCore/PodioLegacyDataSvc.h @@ -40,10 +40,10 @@ class PodioLegacyDataSvc : public DataSvc { public: typedef std::vector> CollRegistry; - virtual StatusCode initialize(); - virtual StatusCode reinitialize(); - virtual StatusCode finalize(); - virtual StatusCode clearStore(); + StatusCode initialize() final; + StatusCode reinitialize() final; + StatusCode finalize() final; + StatusCode clearStore() final; /// Standard Constructor PodioLegacyDataSvc(const std::string& name, ISvcLocator* svc);