-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename action.name to action.id? #32
Comments
I'm not convinced. Is the role of action.name the same as entity ids? (I don't think it is). Is it a requirement that |
I agree with Eric, this would depend on whether I think |
all things being equal, I'd vote for consistency. |
I would not change |
We're adding an ID property to sub-entities. The question came up as to whether we should rename action.name to action.id for consistency.
See: #31 (comment)
The text was updated successfully, but these errors were encountered: