Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename action.name to action.id? #32

Open
kevinswiber opened this issue Feb 22, 2014 · 4 comments
Open

Rename action.name to action.id? #32

kevinswiber opened this issue Feb 22, 2014 · 4 comments

Comments

@kevinswiber
Copy link
Owner

We're adding an ID property to sub-entities. The question came up as to whether we should rename action.name to action.id for consistency.

See: #31 (comment)

@ericelliott
Copy link
Contributor

I'm not convinced. Is the role of action.name the same as entity ids? (I don't think it is). Is it a requirement that action.name is unique? I don't see that requirement in the readme. What about field.name?

@gxxcastillo
Copy link

I agree with Eric, this would depend on whether action.name is intended to be unique. (I've always considered it to be unique even though the spec doesn't state it has to be)

I think field.name makes sense as is, as its consistent with html inputs and its ok to have more than one field with the same name.

@apsoto
Copy link

apsoto commented Feb 25, 2014

all things being equal, I'd vote for consistency.

@ericelliott
Copy link
Contributor

I would not change field.name. I'm on the fence about action.name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants