move(docs/contrib-guidelines): Add contrib guidelines to Maestro #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat a bit, removing obsolete bits. Guidelines will need further work and improvements. Signed-off-by: Denys Fedoryshchenko <[email protected]>
Generally it is good to have such section, even it points to main website. Signed-off-by: Denys Fedoryshchenko <[email protected]>
patersonc
reviewed
Sep 12, 2024
| weight: 1 | ||
| --- | ||
|
|
||
| > KernelCI community contacts are available on the [KernelCI website](https://kernelci.org/community-contact//). |
There was a problem hiding this comment.
nitpick: Only needs a single / on the end of the URL.
| 3. If there is specific way to verify PR is working as expected, mention it in the comments | ||
| 3. Make sure that reviewers' comments and questions are addressed | ||
| 1. When there are comments unanswered for more than 1 month the PR will be closed | ||
| 4. In case there is a need to consult the PR with KernelCI maintainers join the open hours |
There was a problem hiding this comment.
Shall we link to https://docs.kernelci.org/org/#open-hours here?
|
@nuclearcat do you agree with my suggestions? I'm happy to merge either way tbh, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat a bit, removing obsolete bits. Guidelines will need further work and improvements.