Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DENYLIST format #169

Open
chantra opened this issue Nov 9, 2022 · 3 comments
Open

Fix DENYLIST format #169

chantra opened this issue Nov 9, 2022 · 3 comments

Comments

@chantra
Copy link
Contributor

chantra commented Nov 9, 2022

We started to use 3-column format in https://github.com/kernel-patches/bpf/blob/bpf-next/tools/testing/selftests/bpf/DENYLIST.s390x, where the 3rd column identify where the problem is stemming from.

It would be useful to have the format

  1. captured as a header of the file
  2. used in the existing files so the next person that updates the file know what to put in.
@anakryiko
Copy link
Contributor

it's not 3-column format, it's a list of test specifiers and everything after # is a comment. Do you mean to enforce some particular format of a comment or what is this about?

@chantra
Copy link
Contributor Author

chantra commented Nov 10, 2022

it's not 3-column format, it's a list of test specifiers and everything after # is a comment.
Yeah, I think it is a loose-3-column-format. @danielocfb commented about this in the PR. Is that what you meant (test# commentfailing_category)?

@danielocfb
Copy link
Contributor

it's not 3-column format, it's a list of test specifiers and everything after # is a comment.
Yeah, I think it is a loose-3-column-format. @danielocfb commented about this in the PR. Is that what you meant (test# commentfailing_category)?

Yes, what we do in other deny lists. https://github.com/kernel-patches/bpf/blob/bpf-next/tools/testing/selftests/bpf/README.rst#denylisting-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants