Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searching websites like google, youtube, like KISS and Tinybit launcher. #26

Open
magnus-ISU opened this issue Aug 16, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@magnus-ISU
Copy link

Also support adding custom URLs.

Tinybit also allows providing icons when adding a custom launcher. I think that would be nice and then you could show search options in a horizontal list like apps are now, which would be nice.

@kennethnym kennethnym added the enhancement New feature or request label Aug 16, 2022
@kennethnym kennethnym added this to the Stable release milestone Aug 16, 2022
@ghost
Copy link

ghost commented Aug 28, 2022

DuckDuckgo - https://duckduckgo.com/
Brave search - https://search.brave.com/
Startpage - https://www.startpage.com/
SearchX - https://searx.thegpm.org/

These would also be good to implement out of the box for privacy conscious people if possible :)

@kennethnym
Copy link
Owner

Yes, this is planned - you will be able to select the search engine of your choice.

@daffydock
Copy link

daffydock commented Aug 30, 2022

Perhaps, if privacy is a focus then Startpage should not be added, as it was bought by System1. A well known target marketing company.

https://restoreprivacy.com/startpage-system1-privacy-one-group/

@ayecptn
Copy link
Collaborator

ayecptn commented Sep 6, 2022

I think it should be up to the user if he wants a privacy-focused web search. I would let user choose from ~5 different popular search engines and a field where the user can add a custom engine.

@kennethnym I have already implemented a basic web search module, which just uses duckduckgo hardcoded. You can check it out on my fork in the WebSearch branch. Here's a small demo:
starlight_websearch.webm

@kennethnym
Copy link
Owner

That's awesome! I am actually researching how to fetch search suggestions for a given query, seems like there's no direct way of doing so.

@kennethnym
Copy link
Owner

Fun fact: in a really early prototype of Starlight (It used to be called Spotlight!) I was actually able to use DDG's api to fetch definitions for a given search query, for example if you type in "elephant" the launcher will fetch the definition from DDG and show it in the launcher, but I scraped it because personally I don't use it that much. But seeing there's a request for it, I might be able to bring it back.

@ayecptn
Copy link
Collaborator

ayecptn commented Sep 7, 2022

Oh, so you mean fetching and displaying the search results directly in the launcher? Would be nice, but it could be a problem as not every search engine offers an public api.

@kennethnym
Copy link
Owner

kennethnym commented Sep 12, 2022

@ayecptn Yes, afaik only DuckDuckGo has a public API for knowledge search. It can be a separate search module though. For the web search module your implementation is what I have in mind. I am open for a PR - I'm planning to scrap the monetization plan and make this a community project (donations still welcome!)

@ayecptn
Copy link
Collaborator

ayecptn commented Sep 13, 2022

@kennethnym Sounds like a good idea to make two different modules.
I would have done a PR after I implemented the setting to choose from different search engines, but I am to lazy/unmotivated to do anything coding related currently.
But I can also do a PR with the current hardcoded implementation and then a second PR with the settings if you want.

@kennethnym
Copy link
Owner

Don't worry about it - if it is just a simple button for triggering web search then it is easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants