Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope option being ignored completely #71

Open
stugol opened this issue Sep 9, 2016 · 1 comment
Open

scope option being ignored completely #71

stugol opened this issue Sep 9, 2016 · 1 comment

Comments

@stugol
Copy link

stugol commented Sep 9, 2016 •
edited
Loading

You have a bug in instantiate_template_from_string, where opts aren't being passed correctly to Tilt.new. In addition, in lib/angelo/templates.rb, line 61, the code render = ->{ template.render(self, locals) } should respect the :scope option, if set.
@kenichi
Copy link
Owner

kenichi commented Sep 24, 2016

Hello. It sounds like you have all the ingredients for a PR. I've not had much time for this project lately, but am happy to review fixes if you do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenichi @stugol