-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angelo crashes using reel 0.6.x #52
Comments
ah, it looks like the new websocket-driver stuff does not expose the driver. since websocket-driver has its own ping, we should attempt to use that, eh? |
whoa, the new stuff depends on rack and uses Rack::MockRequest? |
I see this too, and it bothered me. It's coming over by |
@digitalextremist do you think it could be useful to have a |
@mighe we can expose |
my immediate fix was to add :driver to the attr_accessor list, but then i saw the mockrequest and went down a rabbit hole of trying to make reel work without that. |
Yeah I am going to make it work without |
If we clean this up and make sure it's solid, I'll cut a |
much has been done as a result of this issue, thanks @mighe. |
Hi @kenichi, I was trying angelo with reel 0.6.0.pre1 and I get the following error:
the problem is here: the code is using a class from the old websocket parser, that has been removed with the websocket-driver integration.
The text was updated successfully, but these errors were encountered: