Fix deleting object's linked DIPS increments the processed obejct count #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Flores <[email protected]>
SugaryLump
force-pushed
the
aflores-dev-fix_deleteaip_objcount
branch
from
67d9bef
to
e545ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting an object would sometimes deleted linked DIPs which would erroneously increment the deletion job's processed object count.
The processDIP method of the delete plugin's workflow now takes a boolean that indicates whether the deletion should increment the processed object count, and this boolean is set to false when the deletion arises from the deletion of linked DIPS.