Add timeout to SSH Agent streams #11290
Open
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11290 +/- ##
===========================================
- Coverage 63.78% 63.76% -0.02%
===========================================
Files 362 362
Lines 38072 38070 -2
===========================================
- Hits 24282 24273 -9
- Misses 13790 13797 +7 ☔ View full report in Codecov by Sentry. |
droidmonkey
force-pushed
the
fix/sshagent-timeout
branch
from
a82283b
to
cd2b2da
Compare
|
I couldn't get the reproduce steps to work. If I make a custom systemd service everything works as expected, but without it the agent doesn't even run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Pending testing in a replicated environment
Type of change