-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official support for Python 3.12 #3287
Labels
Issue: Feature Request
New feature or improvement to existing feature
Comments
astrojuanlu
added
the
Issue: Feature Request
New feature or improvement to existing feature
label
Nov 8, 2023
aiohttp 3.9.0 released |
pyzmq has a fix incoming zeromq/pyzmq#1913 |
One last transitive dependency of aiohttp, multidict, is missing 3.12 wheels aio-libs/multidict#887 |
All transitive dependencies of Kedro have official support for 3.12. Let's go! |
astrojuanlu
added a commit
that referenced
this issue
Feb 2, 2024
Close #3287. Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
7 tasks
astrojuanlu
added a commit
that referenced
this issue
Feb 12, 2024
Close #3287. Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Now the problem is in the Kedro tests themselves:
|
AhdraMeraliQB
added a commit
that referenced
this issue
Mar 12, 2024
* Add official support for Python 3.12 Close #3287. Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Mark broken test as xfail Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Overwrite inherited get to use __getitem__ Signed-off-by: Ahdra Merali <[email protected]> * Appease mypy Signed-off-by: Ahdra Merali <[email protected]> * Fix test Signed-off-by: Ahdra Merali <[email protected]> * Fix test coverage Signed-off-by: Ahdra Merali <[email protected]> * Use spy instead of patch Signed-off-by: Ahdra Merali <[email protected]> * Make comment more clear Signed-off-by: Ahdra Merali <[email protected]> --------- Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> Co-authored-by: Ahdra Merali <[email protected]> Co-authored-by: Ahdra Merali <[email protected]>
AhdraMeraliQB
added a commit
that referenced
this issue
Mar 15, 2024
* Add official support for Python 3.12 Close #3287. Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Mark broken test as xfail Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Overwrite inherited get to use __getitem__ Signed-off-by: Ahdra Merali <[email protected]> * Appease mypy Signed-off-by: Ahdra Merali <[email protected]> * Fix test Signed-off-by: Ahdra Merali <[email protected]> * Fix test coverage Signed-off-by: Ahdra Merali <[email protected]> * Use spy instead of patch Signed-off-by: Ahdra Merali <[email protected]> * Make comment more clear Signed-off-by: Ahdra Merali <[email protected]> * Remove redundant test assert Signed-off-by: Ahdra Merali <[email protected]> * Remove redundant variable Signed-off-by: Ahdra Merali <[email protected]> * Fix broken docs link Signed-off-by: Ahdra Merali <[email protected]> * Fix broken docs link Signed-off-by: Ahdra Merali <[email protected]> * Update docstring to reflect test Signed-off-by: Ahdra Merali <[email protected]> * Add test to ensure deduplication Signed-off-by: Ahdra Merali <[email protected]> * Trim test Signed-off-by: Ahdra Merali <[email protected]> --------- Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Kedro itself probably works on Python 3.12 already, it would be nice to declare official support.
However, installing Kedro is one thing, but installing the typical dependencies might not be straightforward. For example, I just tested the spaceflights starter and most of the dependencies have already published precompiled wheels for Python 3.12 (at least for M1 Mac), but two of them are still problematic as of today:
Context
#2815 was already completed, but officially Kedro does not support Python 3.12 yet.
You can use Kedro on Python 3.12 by manually disabling the warning.
Possible Implementation
Wait a bit until at least the spaceflights starter can be safely installed in most mainstream platforms.
Possible Alternatives
Declare Python 3.12 support already, at the cost of creating some grievance of users that then proceed to install some dependencies.
The text was updated successfully, but these errors were encountered: