Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug found with "unlimitedHours" #18

Open
ghost opened this issue Jul 14, 2015 · 4 comments
Open

Bug found with "unlimitedHours" #18

ghost opened this issue Jul 14, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 14, 2015

I set the parameter "unlimitedHours" to "true". Everything was fine when editing the field with an empty starter value.

But when i am retrieving the data, seems like "unlimitedHours" doesn't work.

I created a Plunker: http://plnkr.co/edit/yBYP3mRgrL3ARcVflBOV?p=preview, there, i set the value "100:00" for the input, but the value i see is "4:00". After the data retrieve, if we try to edit the input we can see that now it's working.

@dimrsilva
Copy link

👍 I have the same issue here.

@smark111
Copy link

Issue still exists. Fix to this will be very helpful.

@Ivutar
Copy link

Ivutar commented Nov 17, 2017

at line 173 replace:

if (currentTime) {
  this._setTime(inst, new Date(0, 0, 0, currentTime[0], currentTime[1], currentTime[2]));
}

to

if (currentTime) {
  this._setTime(inst, (inst.options.unlimitedHours ? currentTime :
    new Date(0, 0, 0, currentTime[0], currentTime[1], currentTime[2])));
}

@ghost
Copy link
Author

ghost commented Nov 20, 2017

Seems good, need @kbwood to approve and integrate this within the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants