From f57d68e1c7c93413e884f0019133eb6702839169 Mon Sep 17 00:00:00 2001 From: Bogdan Kostov Date: Thu, 11 Jul 2024 19:08:54 +0200 Subject: [PATCH] [Fix partially kbss-cvut/record-manager-ui#180] publishRecords does nothing when publishServiceUrl is not configured. --- .../cvut/kbss/study/rest/PatientRecordController.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java b/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java index 91163052..c4b461f0 100644 --- a/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java +++ b/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java @@ -158,11 +158,19 @@ public ResponseEntity createRecord(@RequestBody PatientRecord record) { public RecordImportResult publishRecords( @RequestParam(name = "institution", required = false) String institutionKey, @RequestParam(required = false) MultiValueMap params){ + String publishServiceUrl = configReader.getConfig(ConfigParam.PUBLISH_SERVICE_URL); + if(publishServiceUrl == null || publishServiceUrl.isBlank()) { + LOG.info("No publish service url provided, noop."); + RecordImportResult result = new RecordImportResult(0); + result.addError("Cannot publish completed records. Publish server not configured."); + return result; + } + + // TODO fetch records completed records // final Page result = recordService.findAllFull(RecordFilterMapper.constructRecordFilter(params), // RestUtils.resolvePaging(params)); // List records = result.getContent(); List records = new ArrayList<>(); - String publishServiceUrl = configReader.getConfig(ConfigParam.PUBLISH_SERVICE_URL); LOG.debug("Publishing records."); RecordImportResult response = restTemplate.postForEntity(URI.create(publishServiceUrl), records, RecordImportResult.class).getBody();