Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility use sheet index #6

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Conversation

velios
Copy link
Contributor

@velios velios commented Sep 16, 2023

Reason:
When data is provided by an external user, it is not always possible to agree on a specific sheet name. In such cases, it is convenient to be able to use an index of the sheet.

@kbosompem kbosompem merged commit 897eb1f into kbosompem:main Sep 16, 2023
1 check failed
@velios velios deleted the PassSheetIdx branch September 16, 2023 17:50
@velios
Copy link
Contributor Author

velios commented Sep 16, 2023

My two last PR has crossed sections. They can't merge one after another without errors =( You can do revert and I can make update version of second PR. Or I can just make fix from current version. What you prefer?

@kbosompem
Copy link
Owner

Make a fix from the current version and increment the version number, readme and change log. Really appreciate this. Thanks

@velios
Copy link
Contributor Author

velios commented Sep 16, 2023

Okay, and I assumed that you would upload the changes using the squash and merge method. My commit comments were not prepared for uploading directly to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants