Early stopping based on global acceptance rate #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kazewong , did you get a chance to have a look at this PR? Please do let me know if you want me to make further changes. |
|
@ThibeauWouters Somehow this flew under my radar. I will have a look in the coming week |
|
I like the idea of early stopping. Tho I am going to do a big round of clean up for flowMC, and I think it would be easier for me to add it in after afterward. Instead of merging this PR, I will mark you as a contributor for the early stopping part in the refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #121 and also apparent from my own experiments, the global acceptance rate is actually the best indication of the quality/convergence of a run. Therefore, I have added a few lines of code that implements early stopping based on reaching a desired target global acceptance rate. I have done this in a bit of a hacky way, so feel free to provide feedback or thoughts on how to best approach something like this.