diff --git a/src/data/import/download.rs b/src/data/import/download.rs index 57e7ed9..811baee 100644 --- a/src/data/import/download.rs +++ b/src/data/import/download.rs @@ -11,12 +11,12 @@ use crate::download::{Download, Git, Source}; #[folder = "assets/imports"] struct Asset; -fn git_clone(url: &String, target_path: &Utf8Path, commit: &str) -> Result<(), Error> { +fn git_clone(url: &str, target_path: &Utf8Path, commit: &str) -> Result<(), Error> { let git_cache = crate::GIT_CACHE.get().expect("this has been set earlier"); git_cache .cloner() - .repository_url(url.clone()) + .repository_url(url.to_string()) .target_path(Some(target_path.to_path_buf())) .commit(Some(commit.into())) .do_clone() diff --git a/src/data/import/local.rs b/src/data/import/local.rs index 6fa3891..d6a0ac9 100644 --- a/src/data/import/local.rs +++ b/src/data/import/local.rs @@ -46,8 +46,7 @@ impl super::Import for Local { std::fs::create_dir_all(path_parent).with_context(|| format!("creating {path}"))?; let link_target = if self.path.is_relative() { - let relpath = pathdiff::diff_utf8_paths(&self.path, path_parent).unwrap(); - relpath + pathdiff::diff_utf8_paths(&self.path, path_parent).unwrap() } else { self.path.clone() }; diff --git a/src/generate.rs b/src/generate.rs index 2ba5e3f..db0f485 100644 --- a/src/generate.rs +++ b/src/generate.rs @@ -305,6 +305,7 @@ impl NoBuildReason { enum ConfigureBuildResult { Build(BuildInfo, NinjaRuleSnippets), + #[expect(dead_code, reason = "will use soon")] NoBuild(NoBuildReason), } @@ -318,6 +319,7 @@ impl From for ConfigureBuildResult { // and block/allowlists allow it. // // TODO: configure_build() is approaching 300 LoC. it should be split up. +#[expect(clippy::too_many_arguments, reason = "yeah we know")] fn configure_build( binary: &Module, contexts: &ContextBag,