Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CHANGELOG.md to point to the changelog directory #5708

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

MAVRICK-1
Copy link
Contributor

@MAVRICK-1 MAVRICK-1 commented Oct 18, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:
This PR updates the CHANGELOGS.md to point to the overall changelog directory. The current setup is incomplete and difficult to maintain, so adding this link provides a more streamlined and updated experience.

Which issue(s) this PR fixes:
Part of #5484 (update CHANGELOG.md to point to the changelog directory)

Special notes for your reviewer:
None.

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 18, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.74%. Comparing base (d1433e2) to head (8711b0a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5708   +/-   ##
=======================================
  Coverage   39.74%   39.74%           
=======================================
  Files         650      650           
  Lines       55125    55125           
=======================================
+ Hits        21907    21912    +5     
+ Misses      31809    31805    -4     
+ Partials     1409     1408    -1     
Flag Coverage Δ
unittests 39.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

[FAIL] deployment replicas syncer testing when policy is Divided schedule type, each cluster have more that one replica [It] general case combined hpa scaling and manually modify in Divided type

/retest

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@karmada-bot karmada-bot merged commit ffbbe06 into karmada-io:master Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants