Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines of code is redundant, or undetected bug... #1

Open
dave4723 opened this issue Dec 13, 2017 · 1 comment
Open

Lines of code is redundant, or undetected bug... #1

dave4723 opened this issue Dec 13, 2017 · 1 comment

Comments

@dave4723
Copy link

3d-quickhull/quickhull.h

Lines 1147 to 1149 in 498df74

if (v->x == 0) v->x = 0;
if (v->y == 0) v->y = 0;
if (v->z == 0) v->z = 0;

Hi there,
First of all very very nice codebase! this is realy quality work!

However those lines are ether reduntant because they do nothing or you ment to write
if (v->x != 0) v->x = 0;
i am not sure however because i am just getting familiar with the quickhull algorithm...

@karimnaaji
Copy link
Owner

Hey!

You're right this is redundant and can just go, feel free to submit a PR for this fix if you can, otherwise I'll get to it when I get a chance.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants