Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kadet input type to use external kadet module #846

Open
ramaro opened this issue Aug 20, 2022 · 4 comments
Open

Update kadet input type to use external kadet module #846

ramaro opened this issue Aug 20, 2022 · 4 comments
Assignees
Labels
enhancement enhancement to an existing feature Stale

Comments

@ramaro
Copy link
Member

ramaro commented Aug 20, 2022

Update kadet input type to use external kadet module as it is now available at https://pypi.org/project/kadet/

This will introduce breaking changes to BaseObj's methods:

  • to_dict() to be renamed to dump()
  • update_root() to be renamed to root_file()

cc @ademariag @Moep90 these changes will break https://github.com/kapicorp/kapitan-reference

@ramaro ramaro added the enhancement enhancement to an existing feature label Aug 20, 2022
@ramaro ramaro self-assigned this Aug 20, 2022
@Moep90
Copy link
Contributor

Moep90 commented Aug 23, 2022

Do we have to update the suggested changes here as well kap_0_kadet.md?

@ramaro
Copy link
Member Author

ramaro commented Aug 25, 2022

Do we have to update the suggested changes here as well kap_0_kadet.md?

Yes, we will need to indeed! Once a release is done

@ademariag
Copy link
Contributor

@ramaro kapicorp/kapitan-reference should work now with the new version

Copy link

This issue is stale because it has been open for 1 year with no activity.
Remove the stale label or comment if this issue is still relevant for you.
If not, please close it yourself.

@github-actions github-actions bot added the Stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to an existing feature Stale
Projects
None yet
Development

No branches or pull requests

3 participants