RFC: Add optional Serde support for HashMap #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of Deserialize is based on the implementation of Extend.
yaleman
approved these changes
Mar 3, 2024
Indeed. I did put it into it a separate commit and can drop it if you prefer. |
|
Oh no need, just calling it out. I like keeping 📎 happy |
Firstyear
approved these changes
Mar 5, 2024
|
This is excellent @adamreichold, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Deserializeis based on the implementation ofExtend.I can of course remove the first commit as it is admittedly unrelated and unnecessary for Serde support, it just felt better working in a code base that starts without Clippy warnings and stays that way.