SE Linux binary policy formats #678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules, Kernel and package, all versions.
generalmimon
requested changes
Jul 13, 2023
There was a problem hiding this comment.
@angea Thanks for the submission! The first batch of comments is below (it's not everything I wanted to point out, but at least something to start with):
|
Updated - PTAL. |
GreyCat
reviewed
Jul 14, 2023
GreyCat
reviewed
Jul 14, 2023
|
Updated. PTAL. |
generalmimon
requested changes
Jul 23, 2023
generalmimon
requested changes
Jul 23, 2023
There was a problem hiding this comment.
And here comes some very general feedback, so I won't even directly highlight any specific occurrences - please check out https://doc.kaitai.io/ksy_style_guide.html#attr-id and try to conform to the naming conventions throughout both .ksy specs wherever possible. For example:
- most of the arrays I've seen don't have plural names as they should,
- fields denoting byte size of another field (most often a string) aren't called
len_+ subject as they're supposed to, but they sometimes use_lengthsuffix, sometimes_lensuffix, other times it's justlengthwithout specifying the subject field... - fields that designate the number / count of items are not called
num_+ subject as expected, but instead, it's sometimes "something +_count" (I call it something, not "subject", because "subject" is meant to exactly match the name of the array field, which should be a plural word, e.g.num_nodesspecifies the number of elements of anodeslist), sometimes justcount, other timeslength(which even clashes with the "convention" for byte size) etc.
|
I handled all your previous comments and applied the style guide. |
corkamig
approved these changes
Jul 25, 2023
angea
commented
Jul 26, 2023
corkamig
approved these changes
Jul 26, 2023
|
Could you have another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules, Kernel and package, all versions.