Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set $PSNativeCommandUseErrorActionPreference = $true in a workflow that uses pwsh #806

Merged
merged 13 commits into from
Sep 29, 2024
Merged

Set $PSNativeCommandUseErrorActionPreference = $true in a workflow that uses pwsh #806

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
971e115
Simply add checkers for $LASTEXITCODE in most pwsh steps
kachick Sep 29, 2024
ba43b8f
Intentionally add setup bug to make sure GH-806 actually works or not
kachick Sep 29, 2024
51ddf06
Revert "Simply add checkers for $LASTEXITCODE in most pwsh steps"
kachick Sep 29, 2024
40f2b99
Make default pwsh in GitHub action set $ErrorActionPreference for fai…
kachick Sep 29, 2024
8d6b050
Set $PSNativeCommandErrorActionPreference with $true
kachick Sep 29, 2024
a685f1d
Begins to debug...
kachick Sep 29, 2024
0ec8eac
Add debug print more
kachick Sep 29, 2024
108b753
Add debug print more
kachick Sep 29, 2024
fd0127f
Fix a typo...?
kachick Sep 29, 2024
dd23da9
Fix another typo
kachick Sep 29, 2024
e6906aa
Remove needless testing code
kachick Sep 29, 2024
7037405
Revert "Intentionally add setup bug to make sure GH-806 actually work…
kachick Sep 29, 2024
a510ded
Apply missing name for multi lines step
kachick Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,19 @@ permissions:

defaults:
run:
shell: pwsh
# To respect exit code and make fail-fast behaviors. See GH-617
shell: |
pwsh -Command "$PSVersionTable; $PSNativeCommandUseErrorActionPreference = $true; $ErrorActionPreference = 'Stop'; & '{0}'"

jobs:
inspect_runner:
runs-on: windows-2022
steps:
- name: Print some variables which is applied in GH-617
run: |
$PSVersionTable
$PSNativeCommandUseErrorActionPreference
$ErrorActionPreference
# This job has many comment-out tyle note, agree to ugly, but do NOT remove for now.
# See #443 for detail.
#
Expand Down