There should be nothing that uses a node selector/affinity that is not easily configurable at deploy time

[ns-rlewkowicz]

This is an interesting project. I wonder what the reasoning was behind the need for an aggressive reconciliation loop over a slew of well established deployment models and tools.

It worked great in a dev env, trying to incorporate this into an existing environment has been a nightmare.

This fixes config daemon:

apiVersion: sriovnetwork.openshift.io/v1
kind: SriovOperatorConfig
metadata:
  annotations:
  name: default
  namespace: sriov-network-operator
spec:
  configDaemonNodeSelector:
    node-role.kubernetes.io/worker": "true"
  enableInjector: true
  enableOperatorWebhook: true
  logLevel: 2

But even this is awkward. It doesn't seem to cycle the pods automatically after application.

Then the other DS won't launch. There's a bunch of hard coded node labels.

[ns-rlewkowicz]

If you're here because of label pains, a breakfix for now.

grep -Rl requiredDuringSchedulingIgnoredDuringExecution | grep yaml$
grep -Rl worker: | grep yaml$

You want everything in bindata. Blow all labels and affinites out or modify them to your needs.

make your image:
make image

I don't feel like dissecting their vars, just retag it.

docker tag ghcr.io/k8snetworkplumbingwg/sriov-network-operator:latest yourtag:version

Push your image where ever. Then export and deploy.

export SRIOV_NETWORK_OPERATOR_IMAGE=yourtag:version
make deploy-setup-k8s

[zeeke]

Hi @ns-rlewkowicz ,

NodeSelector fields of the daemonsets are updated in sriovoperatorconfig_controller.go:

sriov-network-operator/controllers/sriovoperatorconfig_controller.go

Line 169 in 4dd75bc

ds.Spec.Template.Spec.NodeSelector = dc.Spec.ConfigDaemonNodeSelector

sriov-network-operator/controllers/sriovoperatorconfig_controller.go

Line 221 in 4dd75bc

ds.Spec.Template.Spec.NodeSelector = dc.Spec.ConfigDaemonNodeSelector

Can you be more specific about the problem you are having with your deploy?

[SchSeba]

Hi @ns-rlewkowicz any update base on the comment from @zeeke ?

[ns-rlewkowicz]

I think this is just a docs gap. It leads with this make system and I'm just a goof I suppose. I can grep around and modify stuff without issue so I thought that was just my life with this product.