Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: MS teams Sink #315

Open
2 tasks done
danportu opened this issue Jan 11, 2024 · 5 comments
Open
2 tasks done

[Feature]: MS teams Sink #315

danportu opened this issue Jan 11, 2024 · 5 comments

Comments

@danportu
Copy link

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

No problem

tested slack sinks to teams and only arrive title

Captura de pantalla 2024-01-10 162050

Solution Description

add MS teams sink
support MS teams incoming webhook

Benefits

Users can choose to sink into Teams

Potential Drawbacks

No response

Additional Information

Teams Docs
Teams Example

@nox1134
Copy link

nox1134 commented Jan 25, 2024

Hi @arbreezy! I'm interested in contributing to this issue. Could you provide guidance on how to get started?

@arbreezy
Copy link
Member

arbreezy commented Mar 24, 2024

@nox1134 apologies for not replying sooner.

Nice, the solution should be straight forward but there are a few parts that have to be updated.

  1. You will have to add a new sink in the sinkreporter
  2. Add your MS teams implementation in a similar fashion with slack to satisfy the interface
  3. Regarding the implementation, we are initialising an HTTP client for all the sinks and you will have to see what is needed to configure(authentication, endpoint, etc..) an MS team webhook
  4. If there are more configs to add, you will have to update the webhook api struct and run make manifests to re-generate the CRD
  5. Atm we have to manually update the Helm chart's CRD template so please update this as well, if 4. is true

PS: I don't have a MS teams so a screenshot or two will be great to see the k8sgpt results 🚀

@danportu
Copy link
Author

@nox1134 are you working on this feature?

@nox1134
Copy link

nox1134 commented May 27, 2024

Hi @danportu! I'm busy with something else right now, so if anyone wants to work on it, they can.

@nox1134 nox1134 removed their assignment May 27, 2024
@arbreezy
Copy link
Member

arbreezy commented Jun 3, 2024

@danportu happy to assign it to you if want to have a go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants