Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run libseccomp tests in parallel #5076

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Oct 4, 2024

Backport a commit that allows us to run the libseccomp tests in parallel. This lets us build runc image in 30-40 seconds instead of 4-5 minutes.

The bash script uses tail options that is not supported in busybox tail so pull in tail from coreutils.

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa ncopa requested a review from a team as a code owner October 4, 2024 08:26
@ncopa ncopa requested review from twz123 and jnummelin October 4, 2024 08:26
@ncopa ncopa added the chore label Oct 4, 2024
embedded-bins/runc/Dockerfile Show resolved Hide resolved
embedded-bins/runc/Dockerfile Outdated Show resolved Hide resolved
embedded-bins/runc/Dockerfile Outdated Show resolved Hide resolved
embedded-bins/runc/Dockerfile Outdated Show resolved Hide resolved
Backport a commit that allows us to run the libseccomp tests in
parallel. This lets us build runc image in 30-40 seconds instead
of 4-5 minutes.

The bash script uses `tail` options that is not supported in busybox
tail so pull in `tail` from coreutils.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa merged commit 9a7b4d1 into k0sproject:main Oct 17, 2024
89 checks passed
@ncopa ncopa deleted the parallel-seccomp-tests branch October 17, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants