Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KS equation #47

Open
maxweissenbacher opened this issue Sep 11, 2024 · 1 comment
Open

KS equation #47

maxweissenbacher opened this issue Sep 11, 2024 · 1 comment

Comments

@maxweissenbacher
Copy link

Hi there,

I'm very interested in using your benchmark. It may be of interest to include the Kuramoto-Sivashinsky equation in the benchmark? You can find an implementation (albeit in the torchrl library; I also have a Gym version lying around somewhere) here:

https://github.com/maxweissenbacher/charot/blob/e2fd88877b5f880b4438ed2af7353394665d7194/solver/KS_environment.py

Max

@jviquerat
Copy link
Owner

Hi, thanks for your message. Indeed it could be interesting
I chose to implement Shkadov instead of KS since KS is actually a simplified version of the Shkadov system.
We are open to PR if you want to propose a KS environment that matches the requirements of the library :) by checking your link I see that it would not be too much work to adapt it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants