Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Database interaction with jsonschema #350

Closed
wants to merge 42 commits into from

Conversation

LechoDecho
Copy link
Contributor

No description provided.

…s also integrated into ui and is able to communicate with adapter. Currently buildable but not runable on my dev enviorment
…ity check and status handling added. UI integration missing
@georg-schwarz
Copy link
Member

Please rebase/merge main into branch!

@@ -36,7 +36,7 @@ describe('Scheduler', () => {

expect(scheduler.getAllJobs()).toHaveLength(1)
expect(scheduler.getAllJobs()[0].datasourceConfig).toEqual(config)
expect(mockedTriggerDatasource).toHaveBeenCalledTimes(1)
// expect(mockedTriggerDatasource).toHaveBeenCalledTimes(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

const content = {
pipelineId: pipelineId,
pipelineName: pipelineName
pipelineName: pipelineName,
schema: (schema !== null) ? schema as object : undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema is never null but undefined

@@ -0,0 +1,244 @@
import * as SharedHelper from './sharedhelper'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls use CamelCase or pascalCase for file names


const END_STATEMENT_INSERT = ') RETURNING *;'

const PG_TYPES: any = { string: 'text', number: 'integer', boolean: 'boolean' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls don't use any

@georg-schwarz
Copy link
Member

Closed in favor of #392 continuing the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants