Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

om health custom health checks? #237

Open
shivaraj-bh opened this issue Sep 26, 2023 · 3 comments
Open

om health custom health checks? #237

shivaraj-bh opened this issue Sep 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@shivaraj-bh
Copy link
Member

shivaraj-bh commented Sep 26, 2023

Is there a need to let users configure custom health checks?

Here's one use-case from on top of my mind:

  • Checking if there are any services running globally; sometimes that can cause problems if we are using services-flake to startup project specific services. If we are looking for an experience where we ensure that, “If health checks pass, then everything will work fine, almost always.”, then this might be a good addition.

Let's list down more such scenarios here and see if this feature is worth adding

@srid srid changed the title nix-health: Is there a need to let users configure custom health checks? nix-health custom health checks? Sep 27, 2023
@srid
Copy link
Collaborator

srid commented Sep 27, 2023

  • Checking if there are any services running globally; sometimes that can cause problems if we are using services-flake to startup project specific services. If we are looking for an experience where we ensure that, “If health checks pass, then everything will work fine, almost always.”, then this might be a good addition.

Can't we instead make services-flake change the process-compose wrapper to check the ports before starting processes up and then print friendly error message? Custom checks may be useful, but I'm not totally sure if this particular use-case should be in the domain of nix-health.

@shivaraj-bh
Copy link
Member Author

  • Checking if there are any services running globally; sometimes that can cause problems if we are using services-flake to startup project specific services. If we are looking for an experience where we ensure that, “If health checks pass, then everything will work fine, almost always.”, then this might be a good addition.

Can't we instead make services-flake change the process-compose wrapper to check the ports before starting processes up and then print friendly error message? Custom checks may be useful, but I'm not totally sure if this particular use-case should be in the domain of nix-health.

This can be done; in terms of UX I had a thought that with health checks the user will be aware that the dev environment might not work as expected and additionally a suggestion could come in handy.

@srid srid transferred this issue from juspay/omnix Apr 5, 2024
@srid
Copy link
Collaborator

srid commented May 31, 2024

Another use case (ulimit -s min value in nammayatri)

image

@srid srid transferred this issue from juspay/nix-health Aug 27, 2024
@srid srid changed the title nix-health custom health checks? om health custom health checks? Aug 27, 2024
@srid srid added the enhancement New feature or request label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants